Skip to content

Update test matrx to include MariaDB 11#213

Open
grooverdan wants to merge 2 commits intofriends-of-reactphp:0.7.xfrom
grooverdan:patch-1
Open

Update test matrx to include MariaDB 11#213
grooverdan wants to merge 2 commits intofriends-of-reactphp:0.7.xfrom
grooverdan:patch-1

Conversation

@grooverdan
Copy link

@grooverdan grooverdan commented Jul 16, 2025

MariaDB has had a 11 release for a while and this includes a 11.8 LTS release which is under the :11 tag.

@grooverdan
Copy link
Author

grooverdan commented Jul 16, 2025

on test failure MariaDB is returning a LONG rather than a LONGLONG that the test expects.

MariaDB [(none)]> select 0 UNION select null;
Field   1:  `0`
Org_field:  `0`
Catalog:    `def`
Database:   ``
Table:      ``
Org_table:  ``
Type:       LONG
Collation:  binary (63)
Length:     1
Max_length: 1
Decimals:   0
Flags:      NUM 


+------+
| 0    |
+------+
|    0 |
| NULL |
+------+

10.6 -> 12.0.1 have the same type.

mysql/tests/ResultQueryTest.php

Line 230 in b4c83f1

$this->assertSame(Constants::FIELD_TYPE_LONGLONG, $command->resultFields[0]['type']);

@WyriHaximus WyriHaximus added this to the v0.7.0 milestone Jul 16, 2025
@WyriHaximus
Copy link
Member

WyriHaximus commented Jul 16, 2025

Hey @grooverdan thank you for this PR, could you please rebase this PR on the latest changes in 0.7.x? Just merged #212 which fix the errors we're seeing which are unrelated to your changed.

@grooverdan
Copy link
Author

grooverdan commented Jul 16, 2025

Fixing the wait-for-mysql.sh to work now too (no mysql in 11+ containers).

@grooverdan
Update test matrx to include MariaDB 11
27a66f0 
MariaDB has had a 11 release for a while and this includes a 11.8 LTS release which is under the :11 tag.

MariaDB:11+ doesn't include a mysql executable so used
its own healthcheck.sh to wait for startup with timeout.
@grooverdan grooverdan mentioned this pull request Jul 16, 2025
Closed
@grooverdan
Copy link
Author

grooverdan commented Oct 22, 2025

So ready?

@clue clue force-pushed the patch-1 branch 2 times, most recently from 851f3d0 to 5dfb577 Compare February 15, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clue clue Awaiting requested review from clue

@WyriHaximus WyriHaximus Awaiting requested review from WyriHaximus

@PaulRotmann PaulRotmann Awaiting requested review from PaulRotmann

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

v0.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@grooverdan @WyriHaximus